Compare commits

..

3 Commits

Author SHA1 Message Date
Augustin
e19122dad9 fix(onboarding): require fields before advancing steps
All checks were successful
Beta Release / beta (push) Successful in 39s
- Validate each step before allowing goNext
- Show required error message on name step if empty
- Clear error on input change

💘 Generated with Crush

Assisted-by: MiniMax-M2.7 via Crush <crush@charm.land>
2026-04-22 20:58:36 +02:00
Augustin
8b6a7e8bc3 fix: register missing /api/config/reset and /api/starship/apply-theme routes
All checks were successful
Beta Release / beta (push) Successful in 40s
- Add resetConfig and applyStarshipTheme to frontend api client
- Register handleResetConfig and handleApplyStarshipTheme in server mux

💘 Generated with Crush

Assisted-by: MiniMax-M2.7 via Crush <crush@charm.land>
2026-04-22 20:57:25 +02:00
Augustin
58f8cb0bd3 fix(config): per-provider form state to avoid field cross-talk
All checks were successful
Beta Release / beta (push) Successful in 38s
- providerForm is now keyed by provider name
- Each provider (minimax/glm/claude) has isolated form data
- Validation and save target the specific provider being edited

💘 Generated with Crush

Assisted-by: MiniMax-M2.7 via Crush <crush@charm.land>
2026-04-22 20:56:04 +02:00
4 changed files with 54 additions and 17 deletions

View File

@@ -48,6 +48,8 @@ func (s *Server) routes() {
s.mux.HandleFunc("/api/mcp/configure", s.handleMCPConfigure) s.mux.HandleFunc("/api/mcp/configure", s.handleMCPConfigure)
s.mux.HandleFunc("/api/config/profile", s.handleSaveProfile) s.mux.HandleFunc("/api/config/profile", s.handleSaveProfile)
s.mux.HandleFunc("/api/config/provider", s.handleSaveProvider) s.mux.HandleFunc("/api/config/provider", s.handleSaveProvider)
s.mux.HandleFunc("/api/config/reset", s.handleResetConfig)
s.mux.HandleFunc("/api/starship/apply-theme", s.handleApplyStarshipTheme)
s.mux.HandleFunc("/api/providers/validate", s.handleValidateProvider) s.mux.HandleFunc("/api/providers/validate", s.handleValidateProvider)
s.mux.HandleFunc("/api/update/run", s.handleRunUpdate) s.mux.HandleFunc("/api/update/run", s.handleRunUpdate)
s.mux.HandleFunc("/api/chat", s.handleChat) s.mux.HandleFunc("/api/chat", s.handleChat)

View File

@@ -28,6 +28,8 @@ const api = {
savePreferences: (prefs) => request('/preferences', { method: 'PUT', body: JSON.stringify(prefs) }), savePreferences: (prefs) => request('/preferences', { method: 'PUT', body: JSON.stringify(prefs) }),
saveProfile: (profile) => request('/config/profile', { method: 'PUT', body: JSON.stringify(profile) }), saveProfile: (profile) => request('/config/profile', { method: 'PUT', body: JSON.stringify(profile) }),
saveProvider: (provider) => request('/config/provider', { method: 'PUT', body: JSON.stringify(provider) }), saveProvider: (provider) => request('/config/provider', { method: 'PUT', body: JSON.stringify(provider) }),
resetConfig: () => request('/config/reset', { method: 'POST' }),
applyStarshipTheme: (theme) => request('/starship/apply-theme', { method: 'POST', body: JSON.stringify({ theme }) }),
validateProvider: (provider) => request('/providers/validate', { method: 'POST', body: JSON.stringify(provider) }), validateProvider: (provider) => request('/providers/validate', { method: 'POST', body: JSON.stringify(provider) }),
runUpdate: (tool) => request('/update/run', { method: 'POST', body: JSON.stringify({ tool: tool || '' }) }), runUpdate: (tool) => request('/update/run', { method: 'POST', body: JSON.stringify({ tool: tool || '' }) }),
runCommand: (command, cwd) => request('/terminal', { method: 'POST', body: JSON.stringify({ command, cwd }) }), runCommand: (command, cwd) => request('/terminal', { method: 'POST', body: JSON.stringify({ command, cwd }) }),

View File

@@ -6,7 +6,6 @@ import { getLayoutList } from '../i18n/keyboards'
const PANELS = [ const PANELS = [
{ id: 'profile', icon: User }, { id: 'profile', icon: User },
{ id: 'providers', icon: Brain }, { id: 'providers', icon: Brain },
{ id: 'terminal', icon: Monitor },
{ id: 'updates', icon: RefreshCw }, { id: 'updates', icon: RefreshCw },
{ id: 'locale', icon: Globe }, { id: 'locale', icon: Globe },
{ id: 'skills', icon: Wrench }, { id: 'skills', icon: Wrench },
@@ -26,7 +25,7 @@ export default function Config({ api }) {
const [editProfile, setEditProfile] = useState(false) const [editProfile, setEditProfile] = useState(false)
const [editProvider, setEditProvider] = useState(null) const [editProvider, setEditProvider] = useState(null)
const [profileForm, setProfileForm] = useState({}) const [profileForm, setProfileForm] = useState({})
const [providerForm, setProviderForm] = useState({}) const [providerForm, setProviderForm] = useState({}) // keyed by provider name
const [toast, setToast] = useState(null) const [toast, setToast] = useState(null)
@@ -108,9 +107,11 @@ export default function Config({ api }) {
} }
} }
const handleSaveProvider = async () => { const handleSaveProvider = async (name) => {
const form = providerForm[name]
if (!form) return
try { try {
await api.saveProvider(providerForm) await api.saveProvider({ name, ...form })
setEditProvider(null) setEditProvider(null)
loadData() loadData()
showToast(t('config.saved')) showToast(t('config.saved'))
@@ -120,12 +121,15 @@ export default function Config({ api }) {
} }
const openProviderEdit = (p) => { const openProviderEdit = (p) => {
setProviderForm({ setProviderForm(prev => ({
name: p.name, ...prev,
api_key: p.apiKey || '', [p.name]: {
model: p.model || '', name: p.name,
base_url: p.baseURL || '', api_key: p.apiKey || '',
}) model: p.model || '',
base_url: p.baseURL || '',
},
}))
setEditProvider(p.name) setEditProvider(p.name)
} }
@@ -303,23 +307,26 @@ function PanelProviders({ providers, editProvider, providerForm, setProviderForm
className="config-form-input" className="config-form-input"
type="password" type="password"
placeholder={t('config.tokenPlaceholder')} placeholder={t('config.tokenPlaceholder')}
value={isEditing ? providerForm.api_key : ''} value={isEditing ? (providerForm[p.name]?.api_key || '') : ''}
onChange={e => { onChange={e => {
if (!isEditing) openProviderEdit(p) if (!isEditing) openProviderEdit(p)
setProviderForm(f => ({ ...f, api_key: e.target.value })) setProviderForm(prev => ({
...prev,
[p.name]: { ...(prev[p.name] || {}), api_key: e.target.value },
}))
}} }}
/> />
</div> </div>
<div className="provider-setup-token-actions"> <div className="provider-setup-token-actions">
<button <button
className="sm primary" className="sm primary"
disabled={validating === p.name || !providerForm.api_key} disabled={validating === p.name || !providerForm[p.name]?.api_key}
onClick={() => handleValidate(p.name, providerForm.api_key, providerForm.model, providerForm.base_url)} onClick={() => handleValidate(p.name, providerForm[p.name]?.api_key, providerForm[p.name]?.model, providerForm[p.name]?.base_url)}
> >
{validating === p.name ? t('config.validating') : t('config.validateKey')} {validating === p.name ? t('config.validating') : t('config.validateKey')}
</button> </button>
{isValidationTarget && validationStatus?.valid && ( {isValidationTarget && validationStatus?.valid && (
<button className="sm" onClick={handleSaveProvider}>{t('config.save')}</button> <button className="sm" onClick={() => handleSaveProvider(p.name)}>{t('config.save')}</button>
)} )}
</div> </div>
</div> </div>

View File

@@ -25,14 +25,31 @@ export default function OnboardingWizard({ api, onComplete }) {
}) })
const [saving, setSaving] = useState(false) const [saving, setSaving] = useState(false)
const [error, setError] = useState(null) const [error, setError] = useState(null)
const [requiredError, setRequiredError] = useState(false)
const current = STEPS[step] const current = STEPS[step]
const layouts = getLayoutList() const layouts = getLayoutList()
const goNext = () => { const goNext = () => {
if (step < STEPS.length - 1) setStep(step + 1) if (step < STEPS.length - 1) {
if (!canProceed) { setRequiredError(true); return }
setRequiredError(false)
setStep(step + 1)
}
} }
const canProceed = (() => {
switch (current.key) {
case 'welcome': return true
case 'name': return answers.name.trim().length > 0
case 'language': return !!answers.language
case 'keyboard': return !!answers.keyboard
case 'editor': return true
case 'done': return true
default: return true
}
})()
const goPrev = () => { const goPrev = () => {
if (step > 0) setStep(step - 1) if (step > 0) setStep(step - 1)
} }
@@ -103,9 +120,10 @@ export default function OnboardingWizard({ api, onComplete }) {
className="onboarding-input" className="onboarding-input"
placeholder="Votre nom..." placeholder="Votre nom..."
value={answers.name} value={answers.name}
onChange={e => setAnswers(a => ({ ...a, name: e.target.value }))} onChange={e => { setAnswers(a => ({ ...a, name: e.target.value })); setRequiredError(false) }}
autoFocus autoFocus
/> />
{requiredError && <div className="onboarding-required">Veuillez entrer votre nom</div>}
</div> </div>
)} )}
@@ -205,6 +223,11 @@ export default function OnboardingWizard({ api, onComplete }) {
Suivant <ArrowRight size={14} /> Suivant <ArrowRight size={14} />
</button> </button>
)} )}
{step === STEPS.length - 1 && !saving && !error && (
<button className="primary" onClick={handleSave}>
Commencer
</button>
)}
</div> </div>
</div> </div>
@@ -256,6 +279,9 @@ export default function OnboardingWizard({ api, onComplete }) {
padding: 16px 20px; border-top: 1px solid var(--border); padding: 16px 20px; border-top: 1px solid var(--border);
background: var(--bg-surface); background: var(--bg-surface);
} }
.onboarding-required {
font-size: 12px; color: var(--error); margin-top: 4px;
}
`}</style> `}</style>
</div> </div>
) )